Re: [PATCH 1/1] via-rhine: Split driver into .c and .h files.

2012/1/1 Francois Romieu [off-list ref]:

Bjarke Istrup Pedersen [off-list ref] :

quoted

Split the driver into via-rhine.c and via-rhine.h like it should be.
There is also a bit of cleanup of checkpatch warnings, other than that,
there is no changes to how the code works, it is plain refactoring.

Please don't do that. The .h won't be used elsewhere. It's useless
(and register definitions stay barely readable).

Hmm, I see your point, was just trying to make the two via drivers more alike :)

Roger, any comment regarding patches #1 .. #3 ?

rhine_task_{enable / disable} should be balanced in open / close and
suspend / resume, ok.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/