Thread (3 messages) flat view 3 messages, 2 authors, 2012-01-02

Re: [PATCH 1/1] via-rhine: Split driver into .c and .h files.

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2012-01-01 22:58:10
Also in: lkml

Bjarke Istrup Pedersen [off-list ref] :
Split the driver into via-rhine.c and via-rhine.h like it should be.
There is also a bit of cleanup of checkpatch warnings, other than that,
there is no changes to how the code works, it is plain refactoring.
Please don't do that. The .h won't be used elsewhere. It's useless
(and register definitions stay barely readable).

Roger, any comment regarding patches #1 .. #3 ?

rhine_task_{enable / disable} should be balanced in open / close and
suspend / resume, ok.

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help