RE: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

David,

Ok, will do as suggested. 

Jiten

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Tuesday, January 24, 2012 12:39 PM
To: Jitendra Kalsaria
Cc: netdev; Ron Mercer; Dept-NX Linux NIC Driver
Subject: Re: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

From: Jitendra Kalsaria <redacted>
Date: Mon, 23 Jan 2012 15:38:52 -0800

Driver was passing -1 so that custom default get used but which
makes it even more sane than 15 which was excessively verbose
printing an unusual amount of messages.

Signed-off-by: Jitendra Kalsaria <redacted>

Please don't move this code away from the canonical way in which
default message levels are handled.

The canonical way is to specify a module param that starts with the
value "-1" which when passed as the first argument to netif_msg_init()
means "use the default mask" which is the second argument.

Moving to a default of "3" makes no sense at all, express the default
in the second argument of netif_msg_init(), not the first.

I'm not applying this patch, use other drivers such as tg3.c as a
guide.