Thread (6 messages) flat view 6 messages, 3 authors, 2012-01-25
STALE5318d

[net PATCH 1/1] qlge:Changing netdev msg level to default debug

From: Jitendra Kalsaria <hidden>
Date: 2012-01-23 23:54:23
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Driver was passing -1 so that custom default get used but which
makes it even more sane than 15 which was excessively verbose
printing an unusual amount of messages.

Signed-off-by: Jitendra Kalsaria <redacted>
---
 drivers/net/ethernet/qlogic/qlge/qlge_main.c |   17 +++--------------
 1 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index b548987..6ad006a 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -52,19 +52,8 @@ MODULE_DESCRIPTION(DRV_STRING " ");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(DRV_VERSION);
 
-static const u32 default_msg =
-    NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
-/* NETIF_MSG_TIMER |	*/
-    NETIF_MSG_IFDOWN |
-    NETIF_MSG_IFUP |
-    NETIF_MSG_RX_ERR |
-    NETIF_MSG_TX_ERR |
-/*  NETIF_MSG_TX_QUEUED | */
-/*  NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */
-/* NETIF_MSG_PKTDATA | */
-    NETIF_MSG_HW | NETIF_MSG_WOL | 0;
-
-static int debug = -1;	/* defaults above */
+#define DEFAULT_DEBUG_MSG_LEVEL 3
+static int debug = DEFAULT_DEBUG_MSG_LEVEL;
 module_param(debug, int, 0664);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 
@@ -4614,7 +4603,7 @@ static int __devinit ql_init_device(struct pci_dev *pdev,
 		err = -EIO;
 		goto err_out2;
 	}
-	qdev->msg_enable = netif_msg_init(debug, default_msg);
+	qdev->msg_enable = netif_msg_init(debug, DEFAULT_DEBUG_MSG_LEVEL);
 	spin_lock_init(&qdev->hw_lock);
 	spin_lock_init(&qdev->stats_lock);
 
-- 
1.7.6.rc1.1.g2c162b
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help