Re: [PATCH 3/3] skge: add byte queue limit support

From: Eric Dumazet <redacted>
Date: Fri, 20 Jan 2012 07:23:44 +0100

Le jeudi 19 janvier 2012 à 16:43 -0800, Stephen Hemminger a écrit :

quoted

This also changes the cleanup logic slightly to aggregate
completed notifications for multiple packets.

Signed-off-by: Stephen Hemminger <redacted>

--- a/drivers/net/ethernet/marvell/skge.c	2012-01-19 16:12:19.000000000 -0800
+++ b/drivers/net/ethernet/marvell/skge.c	2012-01-19 16:42:17.675908798 -0800

@@ -2831,6 +2831,7 @@ static netdev_tx_t skge_xmit_frame(struc
 		netif_stop_queue(dev);
 	}
 
+	netdev_sent_queue(dev, skb->len);

I doubt this is safe, as skb might already be freed by tx completion
handler from another cpu.

Oops, I'll not apply this for now then.