Re: [PATCH 3/3] skge: add byte queue limit support
From: Eric Dumazet <hidden>
Date: 2012-01-20 06:23:49
Le jeudi 19 janvier 2012 à 16:43 -0800, Stephen Hemminger a écrit :
quoted hunk ↗ jump to hunk
This also changes the cleanup logic slightly to aggregate completed notifications for multiple packets. Signed-off-by: Stephen Hemminger <redacted>--- a/drivers/net/ethernet/marvell/skge.c 2012-01-19 16:12:19.000000000 -0800 +++ b/drivers/net/ethernet/marvell/skge.c 2012-01-19 16:42:17.675908798 -0800@@ -2831,6 +2831,7 @@ static netdev_tx_t skge_xmit_frame(struc netif_stop_queue(dev); } + netdev_sent_queue(dev, skb->len);
I doubt this is safe, as skb might already be freed by tx completion handler from another cpu.
quoted hunk ↗ jump to hunk
return NETDEV_TX_OK; mapping_unwind:@@ -2858,11 +2859,9 @@ mapping_error: