Re: [PATCH] pq3: Add default tbi address

quoted

arch/powerpc/boot/dts/fsl/pq3-etsec1-0.dtsi |    5 +++++
arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    5 +++++
2 files changed, 10 insertions(+), 0 deletions(-)

This doesn't seem correct, meaning this should really be in the board .dts not in the IP.

I think the driver should check and warn if this property doesn't exist.

Hmm... in principle, I agree with you. I suppose I was just being
lazy, and avoiding changing all the device trees again. However, it's
not an unreasonable default. A search through *all* of the device
trees for the tbi node indicates that 0x11 is chosen about 50% of the
time.

However, I'll devise a patch which complains if the node isn't found,
and another patch which modifies all of the offending device trees.

Andy