Re: [PATCH] pq3: Add default tbi address

On Dec 2, 2011, at 1:05 AM, Andy Fleming wrote:

The MDIO driver has been changed so that it no longer supports
scanning the MDIO bus for a free address for the TBI PHY. This
feature was fragile, and required scanning the bus before the bus
was fully up and registered. The intended way for FSL devices to
specify the TBI PHY's address is via a tbi node in the device tree.
All of the device trees had such a node, except for the recent p1/p2
trees. Rather than hand-fixing all of those boards, set a default
value (most boards were using 0x11, anyway), and any board which
wants to change it from that default can then override it in its
board dts file.

This fixes an issue where p1/p2 boards would fail to bring up
Ethernet, due to not finding a tbi node.

Is this only needed on 1st controller because its what has external PHY control?

Signed-off-by: Andy Fleming <redacted>
---
arch/powerpc/boot/dts/fsl/pq3-etsec1-0.dtsi |    5 +++++
arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    5 +++++
2 files changed, 10 insertions(+), 0 deletions(-)

This doesn't seem correct, meaning this should really be in the board .dts not in the IP.

I think the driver should check and warn if this property doesn't exist.