Re: drivers/net/usb/asix: bug in asix_get_wol

On Tue, Dec 13, 2011 at 5:03 AM, Eugene [off-list ref] wrote:

Hi Grant,


The problem is that, as it's currently written, asix_get_wol always
returns that wake-on-lan is disabled.

I think that was the intent.

Allan, can you please confirm?

thanks,
grant

Cheers,
Eugene

On 12 December 2011 10:29, Grant Grundler [off-list ref] wrote:

quoted

[+freddy/allan @ ASIX]

On Sat, Dec 10, 2011 at 5:02 PM, Eugene [off-list ref] wrote:

quoted

Dear kernel devs,

Thanks for the commit at
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=4ad1438f025ed8d1e4e95a796ca7f0ad5a22c378,
It successfully stops my adapter from dying when wake-on-lan gets
enabled.

Hi Eugene!
thanks for the "it works!" report.

quoted

However, I've noticed that it has broken asix_get_wol - the
lines

      if (opt & AX_MONITOR_LINK)
              wolinfo->wolopts |= WAKE_PHY;
      if (opt & AX_MONITOR_MAGIC)
              wolinfo->wolopts |= WAKE_MAGIC;

have been accidentally removed.

This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
|    Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.

quoted

The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...

"Too small"? No such thing. :)

cheers,
grant