Dear kernel devs,
Thanks for the commit at
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=4ad1438f025ed8d1e4e95a796ca7f0ad5a22c378,
It successfully stops my adapter from dying when wake-on-lan gets
enabled. However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed. The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
Cheers,
Eugene
However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed.
This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
| Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.
The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
Hi Grant,
The problem is that, as it's currently written, asix_get_wol always
returns that wake-on-lan is disabled.
Cheers,
Eugene
On 12 December 2011 10:29, Grant Grundler [off-list ref] wrote:
[+freddy/allan @ ASIX]
On Sat, Dec 10, 2011 at 5:02 PM, Eugene [off-list ref] wrote:
However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed.
This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
| Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.
quoted
The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed.
This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
| Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.
quoted
The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
From: ASIX Allan Email [office] <hidden> Date: 2011-12-16 03:37:55
Dear Grant and Eugene,
Please refer to the attached file and below statements to modify the asix_get_wol() routine and let us know if this suggestion can solve your issues or not? Thanks a lot.
================
static void
asix_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
{
struct usbnet *dev = netdev_priv(net);
u8 opt;
if (asix_read_cmd(dev, AX_CMD_READ_MONITOR_MODE, 0, 0, 1, &opt) < 0) {
wolinfo->supported = 0;
wolinfo->wolopts = 0;
return;
}
wolinfo->supported = WAKE_PHY | WAKE_MAGIC;
wolinfo->wolopts = 0;
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
}
---
Best regards,
Allan Chou
Technical Support Division
ASIX Electronics Corporation
TEL: 886-3-5799500 ext.228
FAX: 886-3-5799558
E-mail: allan@asix.com.tw
http://www.asix.com.tw/
-----Original Message-----
From: grundler@google.com [mailto:grundler@google.com] On Behalf Of Grant Grundler
Sent: Friday, December 16, 2011 12:48 AM
To: Eugene; Allan Chou
Cc: netdev@vger.kernel.org; Freddy Xin
Subject: Re: drivers/net/usb/asix: bug in asix_get_wol
On Tue, Dec 13, 2011 at 5:03 AM, Eugene [off-list ref] wrote:
Hi Grant,
The problem is that, as it's currently written, asix_get_wol always
returns that wake-on-lan is disabled.
I think that was the intent.
Allan, can you please confirm?
thanks,
grant
Cheers,
Eugene
On 12 December 2011 10:29, Grant Grundler [off-list ref] wrote:
quoted
[+freddy/allan @ ASIX]
On Sat, Dec 10, 2011 at 5:02 PM, Eugene [off-list ref] wrote:
However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed.
This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
| Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.
quoted
The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
From: ASIX Allan Email [office] <hidden> Date: 2011-12-16 05:16:20
Resend without attachment due to below email server error.
========
----- The following addresses had permanent fatal errors -----
[off-list ref]
(reason: 552-5.7.0 Our system detected an illegal attachment on your message. Please)
[off-list ref]
(reason: 552-5.7.0 Our system detected an illegal attachment on your message. Please)
---
Best regards,
Allan Chou
Technical Support Division
ASIX Electronics Corporation
TEL: 886-3-5799500 ext.228
FAX: 886-3-5799558
E-mail: allan@asix.com.tw
http://www.asix.com.tw/
-----Original Message-----
From: ASIX Allan Email [office] [mailto:allan@asix.com.tw]
Sent: Friday, December 16, 2011 11:38 AM
To: 'Grant Grundler'; 'Eugene'
Cc: 'netdev@vger.kernel.org'; 'Freddy Xin'; ASIX Louis [蘇威陸]
Subject: RE: drivers/net/usb/asix: bug in asix_get_wol
Importance: High
Dear Grant and Eugene,
Please refer to the attached file and below statements to modify the asix_get_wol() routine and let us know if this suggestion can solve your issues or not? Thanks a lot.
================
static void
asix_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
{
struct usbnet *dev = netdev_priv(net);
u8 opt;
if (asix_read_cmd(dev, AX_CMD_READ_MONITOR_MODE, 0, 0, 1, &opt) < 0) {
wolinfo->supported = 0;
wolinfo->wolopts = 0;
return;
}
wolinfo->supported = WAKE_PHY | WAKE_MAGIC;
wolinfo->wolopts = 0;
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
}
---
Best regards,
Allan Chou
Technical Support Division
ASIX Electronics Corporation
TEL: 886-3-5799500 ext.228
FAX: 886-3-5799558
E-mail: allan@asix.com.tw
http://www.asix.com.tw/
-----Original Message-----
From: grundler@google.com [mailto:grundler@google.com] On Behalf Of Grant Grundler
Sent: Friday, December 16, 2011 12:48 AM
To: Eugene; Allan Chou
Cc: netdev@vger.kernel.org; Freddy Xin
Subject: Re: drivers/net/usb/asix: bug in asix_get_wol
On Tue, Dec 13, 2011 at 5:03 AM, Eugene [off-list ref] wrote:
Hi Grant,
The problem is that, as it's currently written, asix_get_wol always
returns that wake-on-lan is disabled.
I think that was the intent.
Allan, can you please confirm?
thanks,
grant
Cheers,
Eugene
On 12 December 2011 10:29, Grant Grundler [off-list ref] wrote:
quoted
[+freddy/allan @ ASIX]
On Sat, Dec 10, 2011 at 5:02 PM, Eugene [off-list ref] wrote:
However, I've noticed that it has broken asix_get_wol - the
lines
if (opt & AX_MONITOR_LINK)
wolinfo->wolopts |= WAKE_PHY;
if (opt & AX_MONITOR_MAGIC)
wolinfo->wolopts |= WAKE_MAGIC;
have been accidentally removed.
This wasn't by accident. This comment in the commit log perhaps
doesn't explain sufficiently:
| Remove MONITOR_MODE. In this mode, Received packets are not buffered when
| the remote wakeup is enabled.
quoted
The vendor driver has them, and I've
successfully tested a kernel with these lines included. The change is
too small for me to bother sending in a properly formatted patch...
From: Grant Grundler <hidden> Date: 2011-12-16 22:16:00
On Thu, Dec 15, 2011 at 9:15 PM, ASIX Allan Email [office]
[off-list ref] wrote:
Resend without attachment due to below email server error.
...
-----Original Message-----
From: ASIX Allan Email [office] [mailto:allan@asix.com.tw]
Sent: Friday, December 16, 2011 11:38 AM
To: 'Grant Grundler'; 'Eugene'
Cc: 'netdev@vger.kernel.org'; 'Freddy Xin'; ASIX Louis [蘇威陸]
Subject: RE: drivers/net/usb/asix: bug in asix_get_wol
Importance: High
Dear Grant and Eugene,
Please refer to the attached file and below statements to modify the
asix_get_wol() routine and let us know if this suggestion can solve
your issues or not? Thanks a lot.
Allan,
Thanks for the response but it doesn't answer my previous question.
Let me ask the same question differently.
Does WOL support in asix driver need more than the four lines of code?
Ie does MONITOR_MODE need to be enabled or anything like that?
This looks remarkably similar to the code Eugene said enables WOL for
him (and it works). I not able to find any difference.
If you believe it was a mistake to remove these four lines of code,
please submit a patch (See Documentation/SubmittingPatches) to add
them back. You can add a "Tested-by: Eugene [off-list ref]"
line after your own "Signed-off-by:" in the patch.
thanks!
grant
Dear Grant,
I will double check this issue and submit the revised patch to Linux kernel mainline source next week. Thanks a lot for your great helps.
---
Best regards,
Allan Chou
Technical Support Division
ASIX Electronics Corporation
TEL: 886-3-5799500 ext.228
FAX: 886-3-5799558
E-mail: allan@asix.com.tw
http://www.asix.com.tw/
-----Original Message-----
From: grundler@google.com [mailto:grundler@google.com] On Behalf Of Grant Grundler
Sent: Saturday, December 17, 2011 6:16 AM
To: ASIX Allan Email [office]
Cc: Eugene; netdev@vger.kernel.org; Freddy Xin; ASIX Louis [蘇威陸]
Subject: Re: drivers/net/usb/asix: bug in asix_get_wol
On Thu, Dec 15, 2011 at 9:15 PM, ASIX Allan Email [office]
[off-list ref] wrote:
Resend without attachment due to below email server error.
...
-----Original Message-----
From: ASIX Allan Email [office] [mailto:allan@asix.com.tw]
Sent: Friday, December 16, 2011 11:38 AM
To: 'Grant Grundler'; 'Eugene'
Cc: 'netdev@vger.kernel.org'; 'Freddy Xin'; ASIX Louis [蘇威陸]
Subject: RE: drivers/net/usb/asix: bug in asix_get_wol
Importance: High
Dear Grant and Eugene,
Please refer to the attached file and below statements to modify the
asix_get_wol() routine and let us know if this suggestion can solve
your issues or not? Thanks a lot.
Allan,
Thanks for the response but it doesn't answer my previous question.
Let me ask the same question differently.
Does WOL support in asix driver need more than the four lines of code?
Ie does MONITOR_MODE need to be enabled or anything like that?
This looks remarkably similar to the code Eugene said enables WOL for
him (and it works). I not able to find any difference.
If you believe it was a mistake to remove these four lines of code,
please submit a patch (See Documentation/SubmittingPatches) to add
them back. You can add a "Tested-by: Eugene [off-list ref]"
line after your own "Signed-off-by:" in the patch.
thanks!
grant