Re: [PATCH net-next] drivers/net: use IS_ENABLED(CONFIG_IPV6)

Le samedi 10 décembre 2011 à 16:51 -0800, Joe Perches a écrit :

On Sat, 2011-12-10 at 23:29 +0100, Eric Dumazet wrote:

quoted

Le samedi 10 décembre 2011 à 14:00 -0800, Joe Perches a écrit :

quoted

Instead of testing defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

[]

quoted

quoted

diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c

[]

quoted

quoted

@@ -3516,7 +3516,7 @@ static int cnic_get_v4_route(struct sockaddr_in *dst_addr,
 static int cnic_get_v6_route(struct sockaddr_in6 *dst_addr,
 			     struct dst_entry **dst)
 {
-#if defined(CONFIG_IPV6) || (defined(CONFIG_IPV6_MODULE) && defined(MODULE))
+#if IS_ENABLED(CONFIG_IPV6)

Are you sure this is equivalent ?

I believe so.

KBUILD add -DMODULE to the compile options when
building for modules.

You didnt answer my question or you dont understand your change.

I wonder why.

Point was : IPV6 compiled as a module, and _this_ driver compiled
staticaly.

Did you tried this combination ?