Re: [PATCH 1/2] udp_diag: Make it module when ipv6 is a module
From: Eric Dumazet <hidden>
Date: 2011-12-10 11:00:27
Le samedi 10 décembre 2011 à 13:33 +0400, Pavel Emelyanov a écrit :
quoted hunk ↗ jump to hunk
Eric Dumazet reported, that when inet_diag is built-in the udp_diag also goes built-in and when ipv6 is a module the udp6 lookup symbol is not found. LD .tmp_vmlinux1 net/built-in.o: In function `udp_dump_one': udp_diag.c:(.text+0xa2b40): undefined reference to `__udp6_lib_lookup' make: *** [.tmp_vmlinux1] Erreur 1 Fix this by making udp diag build mode depend on both -- inet diag and ipv6. Reported-by: Eric Dumazet <redacted> Signed-off-by: Pavel Emelyanov <redacted> ---diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index a51e33e..1a8f93b 100644 --- a/net/ipv4/Kconfig +++ b/net/ipv4/Kconfig@@ -411,7 +411,7 @@ config INET_TCP_DIAG config INET_UDP_DIAG depends on INET_DIAG - def_tristate INET_DIAG + def_tristate INET_DIAG && IPV6 menuconfig TCP_CONG_ADVANCED bool "TCP: advanced congestion control"
Thanks ! Acked-by: Eric Dumazet <redacted>