Thread (1 message) 1 message, 1 author, 2011-12-02

Re: [PATCH] datapath: Fix build breakage on kernel 2.6.40

From: Zhi Yong Wu <hidden>
Date: 2011-12-02 02:25:21

Possibly related (same subject, not in this thread)

On Thu, Dec 1, 2011 at 5:55 AM, Jesse Gross [off-list ref] wrote:
On Wed, Nov 23, 2011 at 1:58 AM, Zhi Yong Wu [off-list ref] wrote:
quoted
diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h
index 311bfdb..22ba2e6 100644
--- a/datapath/linux/compat/include/linux/skbuff.h
+++ b/datapath/linux/compat/include/linux/skbuff.h
@@ -239,7 +239,7 @@ static inline struct page *skb_frag_page(const skb_frag_t *frag)
 }
 #endif

-#if LINUX_VERSION_CODE < KERNEL_VERSION(3,0,0)
+#ifndef HAVE_SKB_RESET_MAC_LEN
2.6.40 is the early name for 3.0.  Does it work if you just replace
the check with KERNEL_VERSION(2,6,40)?
Yeah, it can work now, but i don't know if this issue exist on other
old kernel version < 2.6.40.

Should we send one updated patch for this based on your suggestion?


-- 
Regards,

Zhi Yong Wu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help