Re: [PATCH] datapath: Fix build breakage on kernel 2.6.40

On Thu, Dec 1, 2011 at 6:25 PM, Zhi Yong Wu [off-list ref] wrote:

On Thu, Dec 1, 2011 at 5:55 AM, Jesse Gross [off-list ref] wrote:

quoted

On Wed, Nov 23, 2011 at 1:58 AM, Zhi Yong Wu [off-list ref] wrote:

quoted

diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h
index 311bfdb..22ba2e6 100644
--- a/datapath/linux/compat/include/linux/skbuff.h
+++ b/datapath/linux/compat/include/linux/skbuff.h

@@ -239,7 +239,7 @@ static inline struct page *skb_frag_page(const skb_frag_t *frag)

 }
 #endif

-#if LINUX_VERSION_CODE < KERNEL_VERSION(3,0,0)
+#ifndef HAVE_SKB_RESET_MAC_LEN

2.6.40 is the early name for 3.0.  Does it work if you just replace
the check with KERNEL_VERSION(2,6,40)?

Yeah, it can work now, but i don't know if this issue exist on other
old kernel version < 2.6.40.

Usually we just do these types of checks as we see examples of actual
backporting to avoid having hundreds of tests at configure time.  In
this case, I think the issue is just a difference in how the same
kernel is numbered not backporting, so there isn't really a reason to
believe that this is a bigger problem.

Should we send one updated patch for this based on your suggestion?

That would be great, thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev