Thread (36 messages) 36 messages, 5 authors, 2011-12-07

Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy

From: Mark Lord <hidden>
Date: 2011-11-09 18:27:42
Also in: lkml

On 11-11-09 12:47 PM, Ben Hutchings wrote:
On Wed, 2011-11-09 at 12:31 -0500, Mark Lord wrote:
[...]
quoted
+static int ax88172_link_reset(struct usbnet *dev)
+{
+       u16 lpa;
+       u16 adv;
+       u16 res;
+       u8 mode;
+
+       mode = AX_MEDIUM_TX_ABORT_ALLOW | AX_MEDIUM_FLOW_CONTROL_EN;
+       lpa = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_LPA);
+       adv = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_ADVERTISE);
+       res = mii_nway_result(lpa|adv);
[...]

The argument to mii_nway_result() must be lpa & adv (the intersection of
supported modes, not the union!).

Excellent.  Fixed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help