Thread (36 messages) 36 messages, 5 authors, 2011-12-07

Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy

From: Ben Hutchings <hidden>
Date: 2011-11-09 17:47:43
Also in: lkml

On Wed, 2011-11-09 at 12:31 -0500, Mark Lord wrote:
[...]
+static int ax88172_link_reset(struct usbnet *dev)
+{
+       u16 lpa;
+       u16 adv;
+       u16 res;
+       u8 mode;
+
+       mode = AX_MEDIUM_TX_ABORT_ALLOW | AX_MEDIUM_FLOW_CONTROL_EN;
+       lpa = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_LPA);
+       adv = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_ADVERTISE);
+       res = mii_nway_result(lpa|adv);
[...]

The argument to mii_nway_result() must be lpa & adv (the intersection of
supported modes, not the union!).

Ben

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help