Re: [net-next 6/6] ixgbe: change the eeprom version reported by ethtool
From: Joe Perches <joe@perches.com>
Date: 2011-10-17 15:57:16
On Mon, 2011-10-17 at 05:21 -0700, Jeff Kirsher wrote:
From: Emil Tantilov <redacted> Use 32bit value starting at offset 0x2d for displaying the firmware version in ethtool. This should work for all current ixgbe HW
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
[]
- snprintf(firmware_version, sizeof(firmware_version), "%d.%d-%d", - (adapter->eeprom_version & 0xF000) >> 12, - (adapter->eeprom_version & 0x0FF0) >> 4, - adapter->eeprom_version & 0x000F); + nvm_track_id = (adapter->eeprom_verh << 16) | + adapter->eeprom_verl; + snprintf(firmware_version, sizeof(firmware_version), "0x%08x", + nvm_track_id);
Is ethtool output like proc output considered an abi that should not be changed?