Re: [PATCH net-next] bonding: fix wrong port enabling in 802.3ad
flat view
From: Jay Vosburgh <hidden>
Date: 2011-10-13 17:47:57
Flavio Leitner [off-list ref] wrote:
The port shouldn't be enabled unless its current MUX state is DISTRIBUTING which is correctly handled by ad_mux_machine(), otherwise the packet sent can be lost because the other end may not be ready. The issue happens on every port initialization, but as the ports are expected to move quickly to DISTRIBUTING, it doesn't cause much problem. However, it does cause constant packet loss if the other peer has the port configured to stay in STANDBY (i.e. SYNC set to OFF).
This may explain another misbehavior I've been looking into: if the bond's outgoing LACPDUs are lost (never received by the switch), but the switch's incoming LACPDUs are received, bonding puts the port into use, and packets to the switch are dropped by the switch.
Signed-off-by: Flavio Leitner <redacted> --- The comments there suggests it was a workaround for losses of link events, but I couldn't track the changelog as it seems to be pretty old. Thus, as all the link notification stuff has been improved a lot, maybe this is not an issue anymore. At least, I didn't find any problem while unplugging/plugging cables here.
I believe this code fragment is original to the 802.3ad submission, which would have been around 2003 or so. Did you check the standard for what it says should happen in this case? I'm guessing this is something not specified by the standard, given the comment, but we should check to make sure. -J
quoted hunk ↗ jump to hunk
drivers/net/bonding/bond_3ad.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 47b928e..b33c099 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c@@ -1135,13 +1135,6 @@ static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port)__record_pdu(lacpdu, port); port->sm_rx_timer_counter = __ad_timer_to_ticks(AD_CURRENT_WHILE_TIMER, (u16)(port->actor_oper_port_state & AD_STATE_LACP_TIMEOUT)); port->actor_oper_port_state &= ~AD_STATE_EXPIRED; - // verify that if the aggregator is enabled, the port is enabled too. - //(because if the link goes down for a short time, the 802.3ad will not - // catch it, and the port will continue to be disabled) - if (port->aggregator - && port->aggregator->is_active - && !__port_is_enabled(port)) - __enable_port(port); break; default: //to silence the compiler break; -- 1.7.6
--- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com