Re: [PATCH 4/4] net/fec: add imx6q enet support
flat view
From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2011-09-18 18:09:12
Also in:
linux-arm-kernel
Shawn Guo [off-list ref] : [...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/fec.c b/drivers/net/fec.c index 04206e4..849cb0b 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c@@ -442,18 +453,23 @@ fec_restart(struct net_device *ndev, int duplex) /* Enable flow control and length check */ rcntl |= 0x40000000 | 0x00000020; - /* MII or RMII */ + /* RGMII, RMII or MII */ + if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII) + rcntl |= (1 << 6); if (fep->phy_interface == PHY_INTERFACE_MODE_RMII)
^^^^ missing "else" [...]
quoted hunk ↗ jump to hunk
+ /* 1G, 100M or 10M */ + if (fep->phy_dev) { + if (fep->phy_dev->speed == SPEED_1000) + ecntl |= (1 << 8); + else if (fep->phy_dev->speed == SPEED_100) + rcntl &= ~(1 << 9); + else + rcntl |= (1 << 9); + }
[...]
quoted hunk ↗ jump to hunk
+ if (id_entry->driver_data & FEC_QUIRK_ENET_MAC) { + /* enable ENET endian swap */ + ecntl |= (1 << 8);
I do not understand why the endian swap bit of ecntl needs to be set the same in these two different paths, especially as the latter handles the old faulty imx28 and the former the newly fixed imx6q. Typo ? -- Ueimor