Re: [PATCH v2 2/9] Kernel Memory cgroup
flat view
From: Paul Menage <hidden>
Date: 2011-09-07 05:24:34
Also in:
linux-mm, lkml
On Tue, Sep 6, 2011 at 9:23 PM, Glauber Costa [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+ +struct kmem_cgroup { + struct cgroup_subsys_state css; + struct kmem_cgroup *parent; +};
There's a parent pointer in css.cgroup, so you shouldn't need a separate one here. Most cgroup subsystems define this structure (and the below accessor functions) in their .c file rather than exposing it to the world? Does this subsystem particularly need it exposed?
quoted hunk ↗ jump to hunk
+ +static struct cgroup_subsys_state *kmem_create( + struct cgroup_subsys *ss, struct cgroup *cgrp) +{ + struct kmem_cgroup *sk = kzalloc(sizeof(*sk), GFP_KERNEL);
kcg or just cg would be a better name? Paul