RE: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Monday, September 26, 2011 9:47 AM
To: Ben Hutchings
Cc: Rose, Gregory V; Kirsher, Jeffrey T; davem@davemloft.net;
netdev@vger.kernel.org; gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Mon, 26 Sep 2011 17:41:59 +0100
Ben Hutchings [off-list ref] wrote:

quoted

On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:

quoted

quoted

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net; netdev@vger.kernel.org;
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:

quoted

From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>

See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.

In this case I have no idea how to proceed.  I'll go back and stare at

it some more.

quoted

Where is this structure used on the wire?  I just don't see it.

If the modified iproute2 crashes on older kernels, that's presumably
because it's not correctly handling the case where IFLA_VF_SPOOFCHK is
missing.  Nothing to do with the size of this structure.

The proposed code is fine because the vf_info is not used by any code
in iproute right now and I doubt that any other tools are using it either.

As I mentioned in another post to this thread the ip tool works fine on older kernels when you do the set operation.  It's when you run the ip link show command that you can get a seg fault because the ip tool is looking for a spoof check value set by the kernel that doesn't exist.  I'll see what I can do to fix that up and respin the patch.

- Greg