[net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

Subsystems: networking drivers, the rest

15 messages, 6 authors, 2011-11-18 · open the first message on its own page

[net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Jeff Kirsher <hidden>
Date: 2011-09-25 08:23:21

From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 include/linux/if_link.h |    7 +++++++
 ip/ipaddress.c          |    6 ++++++
 ip/iplink.c             |   15 +++++++++++++++
 man/man8/ip.8           |    4 +++-
 4 files changed, 31 insertions(+), 1 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 304c44f..e421f60 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@ -277,6 +277,7 @@ enum {
 	IFLA_VF_MAC,		/* Hardware queue specific attributes */
 	IFLA_VF_VLAN,
 	IFLA_VF_TX_RATE,	/* TX Bandwidth Allocation */
+	IFLA_VF_SPOOFCHK,	/* Spoof Checking on/off switch */
 	__IFLA_VF_MAX,
 };
 
@@ -298,12 +299,18 @@ struct ifla_vf_tx_rate {
 	__u32 rate; /* Max TX bandwidth in Mbps, 0 disables throttling */
 };
 
+struct ifla_vf_spoofchk {
+	__u32 vf;
+	__u32 setting;
+};
+
 struct ifla_vf_info {
 	__u32 vf;
 	__u8 mac[32];
 	__u32 vlan;
 	__u32 qos;
 	__u32 tx_rate;
+	__u32 spoofchk;
 };
 
 /* VF ports management section
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 85f05a2..7e6ac50 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -197,6 +197,7 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
 	struct ifla_vf_mac *vf_mac;
 	struct ifla_vf_vlan *vf_vlan;
 	struct ifla_vf_tx_rate *vf_tx_rate;
+	struct ifla_vf_spoofchk *vf_spoofchk;
 	struct rtattr *vf[IFLA_VF_MAX+1];
 	SPRINT_BUF(b1);
 
@@ -210,6 +211,7 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
 	vf_mac = RTA_DATA(vf[IFLA_VF_MAC]);
 	vf_vlan = RTA_DATA(vf[IFLA_VF_VLAN]);
 	vf_tx_rate = RTA_DATA(vf[IFLA_VF_TX_RATE]);
+	vf_spoofchk = RTA_DATA(vf[IFLA_VF_SPOOFCHK]);
 
 	fprintf(fp, "\n    vf %d MAC %s", vf_mac->vf,
 		ll_addr_n2a((unsigned char *)&vf_mac->mac,
@@ -220,6 +222,10 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
 		fprintf(fp, ", qos %d", vf_vlan->qos);
 	if (vf_tx_rate->rate)
 		fprintf(fp, ", tx rate %d (Mbps)", vf_tx_rate->rate);
+	if (vf_spoofchk->setting)
+		fprintf(fp, ", spoof checking on");
+	else
+		fprintf(fp, ", spoof checking off");
 }
 
 int print_linkinfo(const struct sockaddr_nl *who,
diff --git a/ip/iplink.c b/ip/iplink.c
index e5325a6..f4a5243 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -71,7 +71,10 @@ void iplink_usage(void)
 	fprintf(stderr, "			  [ alias NAME ]\n");
 	fprintf(stderr, "	                  [ vf NUM [ mac LLADDR ]\n");
 	fprintf(stderr, "				   [ vlan VLANID [ qos VLAN-QOS ] ]\n");
+
 	fprintf(stderr, "				   [ rate TXRATE ] ] \n");
+
+	fprintf(stderr, "				   [ spoofchk { on | off} ] ] \n");
 	fprintf(stderr, "			  [ master DEVICE ]\n");
 	fprintf(stderr, "			  [ nomaster ]\n");
 	fprintf(stderr, "       ip link show [ DEVICE | group GROUP ]\n");
@@ -228,6 +231,18 @@ int iplink_parse_vf(int vf, int *argcp, char ***argvp,
 			ivt.vf = vf;
 			addattr_l(&req->n, sizeof(*req), IFLA_VF_TX_RATE, &ivt, sizeof(ivt));
 		
+		} else if (matches(*argv, "spoofchk") == 0) {
+			struct ifla_vf_spoofchk ivs;
+			NEXT_ARG();
+			if (matches(*argv, "on") == 0)
+				ivs.setting = 1;
+			else if (matches(*argv, "off") == 0)
+				ivs.setting = 0;
+			else
+				invarg("Invalid \"spoofchk\" value\n", *argv);
+			ivs.vf = vf;
+			addattr_l(&req->n, sizeof(*req), IFLA_VF_SPOOFCHK, &ivs, sizeof(ivs));
+
 		} else {
 			/* rewind arg */
 			PREV_ARG();
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index 27993a4..cd7b97a 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -100,7 +100,9 @@ ip \- show / manipulate routing, devices, policy routing and tunnels
 .B qos
 .IR VLAN-QOS " ] ] ["
 .B rate
-.IR TXRATE " ] |"
+.IR TXRATE " ] ["
+.B spoofchk { on | off }
+] |
 .br
 .B master
 .IR DEVICE
-- 
1.7.6.2

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Stephen Hemminger <hidden>
Date: 2011-09-25 17:23:55

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of structure.
Need to have new version of iproute work with older kernels.

RE: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Rose, Gregory V <hidden>
Date: 2011-09-26 16:21:49

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net; netdev@vger.kernel.org;
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.
In this case I have no idea how to proceed.  I'll go back and stare at it some more.

- Greg

RE: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Ben Hutchings <hidden>
Date: 2011-09-26 16:42:03

On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:
quoted
-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net; netdev@vger.kernel.org;
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.
In this case I have no idea how to proceed.  I'll go back and stare at it some more.
Where is this structure used on the wire?  I just don't see it.

If the modified iproute2 crashes on older kernels, that's presumably
because it's not correctly handling the case where IFLA_VF_SPOOFCHK is
missing.  Nothing to do with the size of this structure.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Stephen Hemminger <hidden>
Date: 2011-09-26 16:47:29

On Mon, 26 Sep 2011 17:41:59 +0100
Ben Hutchings [off-list ref] wrote:
On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:
quoted
quoted
-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net; netdev@vger.kernel.org;
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.
In this case I have no idea how to proceed.  I'll go back and stare at it some more.
Where is this structure used on the wire?  I just don't see it.

If the modified iproute2 crashes on older kernels, that's presumably
because it's not correctly handling the case where IFLA_VF_SPOOFCHK is
missing.  Nothing to do with the size of this structure.
The proposed code is fine because the vf_info is not used by any code
in iproute right now and I doubt that any other tools are using it either.

RE: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Rose, Gregory V <hidden>
Date: 2011-09-26 16:59:02

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Monday, September 26, 2011 9:47 AM
To: Ben Hutchings
Cc: Rose, Gregory V; Kirsher, Jeffrey T; davem@davemloft.net;
netdev@vger.kernel.org; gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Mon, 26 Sep 2011 17:41:59 +0100
Ben Hutchings [off-list ref] wrote:
quoted
On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:
quoted
quoted
-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net; netdev@vger.kernel.org;
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.
In this case I have no idea how to proceed.  I'll go back and stare at
it some more.
quoted
Where is this structure used on the wire?  I just don't see it.

If the modified iproute2 crashes on older kernels, that's presumably
because it's not correctly handling the case where IFLA_VF_SPOOFCHK is
missing.  Nothing to do with the size of this structure.
The proposed code is fine because the vf_info is not used by any code
in iproute right now and I doubt that any other tools are using it either.
As I mentioned in another post to this thread the ip tool works fine on older kernels when you do the set operation.  It's when you run the ip link show command that you can get a seg fault because the ip tool is looking for a spoof check value set by the kernel that doesn't exist.  I'll see what I can do to fix that up and respin the patch.

- Greg

RE: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Christian Benvenuti (benve) <hidden>
Date: 2011-09-26 20:54:55

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Stephen Hemminger
Sent: Monday, September 26, 2011 9:47 AM
To: Ben Hutchings
Cc: Rose, Gregory V; Kirsher, Jeffrey T; davem@davemloft.net;
netdev@vger.kernel.org; gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Mon, 26 Sep 2011 17:41:59 +0100
Ben Hutchings [off-list ref] wrote:
quoted
On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:
quoted
quoted
-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Sunday, September 25, 2011 10:24 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; davem@davemloft.net;
netdev@vger.kernel.org;
quoted
quoted
quoted
gospo@redhat.com
Subject: Re: [net-next] iproute2: Add new command to IP link to
enable/disable VF spoof check

On Sun, 25 Sep 2011 01:23:18 -0700
Jeff Kirsher [off-list ref] wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking
enable/disable
quoted
quoted
quoted
quoted
Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
See my comments about ABI compatibility. Can't just grow size of
structure.
Need to have new version of iproute work with older kernels.
In this case I have no idea how to proceed.  I'll go back and
stare
at it some more.
quoted
Where is this structure used on the wire?  I just don't see it.

If the modified iproute2 crashes on older kernels, that's presumably
because it's not correctly handling the case where IFLA_VF_SPOOFCHK
is
quoted
missing.  Nothing to do with the size of this structure.
The proposed code is fine because the vf_info is not used by any code
in iproute right now and I doubt that any other tools are using it
either.
Does it mean that a Netlink interface becomes official (and backward
compatibility
should not be broken) only once iproute2 starts supporting it?

/Chris

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: David Miller <davem@davemloft.net>
Date: 2011-09-26 21:01:03

From: "Christian Benvenuti (benve)" <redacted>
Date: Mon, 26 Sep 2011 15:54:53 -0500
Does it mean that a Netlink interface becomes official (and backward
compatibility should not be broken) only once iproute2 starts
supporting it?
It needs to be analyzed on a case-by-case basis.  Sometimes we can quickly
fix a poorly designed netlink interface is no major tool takes on use of
the feature.

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Stephen Hemminger <hidden>
Date: 2011-09-26 21:20:02

On Mon, 26 Sep 2011 17:00:49 -0400 (EDT)
David Miller [off-list ref] wrote:
From: "Christian Benvenuti (benve)" <redacted>
Date: Mon, 26 Sep 2011 15:54:53 -0500
quoted
Does it mean that a Netlink interface becomes official (and backward
compatibility should not be broken) only once iproute2 starts
supporting it?
It needs to be analyzed on a case-by-case basis.  Sometimes we can quickly
fix a poorly designed netlink interface is no major tool takes on use of
the feature.
If an interface changes before an official release, there is no
problem. I.e. if an interface goes through multiple versions while
in net-next (or a bug fix during 3.X-rc*) that's fine.

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: David Miller <davem@davemloft.net>
Date: 2011-09-26 21:27:12

From: Stephen Hemminger <redacted>
Date: Mon, 26 Sep 2011 14:19:59 -0700
If an interface changes before an official release, there is no
problem. I.e. if an interface goes through multiple versions while
in net-next (or a bug fix during 3.X-rc*) that's fine.
Right.

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Greg Rose <hidden>
Date: 2011-11-17 23:39:46


On 9/25/2011 1:23 AM, Jeff Kirsher wrote:
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
Stephen,

I don't see that this patch was ever applied to your tree.  Was there some problem with it that I missed?  Maybe I'm looking at the wrong tree?

Was just wondering...

Regards,

- Greg
quoted hunk
---
include/linux/if_link.h | 7 +++++++
ip/ipaddress.c | 6 ++++++
ip/iplink.c | 15 +++++++++++++++
man/man8/ip.8 | 4 +++-
4 files changed, 31 insertions(+), 1 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 304c44f..e421f60 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@ -277,6 +277,7 @@ enum {
IFLA_VF_MAC, /* Hardware queue specific attributes */
IFLA_VF_VLAN,
IFLA_VF_TX_RATE, /* TX Bandwidth Allocation */
+ IFLA_VF_SPOOFCHK, /* Spoof Checking on/off switch */
__IFLA_VF_MAX,
};
@@ -298,12 +299,18 @@ struct ifla_vf_tx_rate {
__u32 rate; /* Max TX bandwidth in Mbps, 0 disables throttling */
};

+struct ifla_vf_spoofchk {
+ __u32 vf;
+ __u32 setting;
+};
+
struct ifla_vf_info {
__u32 vf;
__u8 mac[32];
__u32 vlan;
__u32 qos;
__u32 tx_rate;
+ __u32 spoofchk;
};

/* VF ports management section
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 85f05a2..7e6ac50 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -197,6 +197,7 @@ static void print_vfinfo(FILE *fp, struct rtattr
*vfinfo)
struct ifla_vf_mac *vf_mac;
struct ifla_vf_vlan *vf_vlan;
struct ifla_vf_tx_rate *vf_tx_rate;
+ struct ifla_vf_spoofchk *vf_spoofchk;
struct rtattr *vf[IFLA_VF_MAX+1];
SPRINT_BUF(b1);
@@ -210,6 +211,7 @@ static void print_vfinfo(FILE *fp, struct rtattr
*vfinfo)
vf_mac = RTA_DATA(vf[IFLA_VF_MAC]);
vf_vlan = RTA_DATA(vf[IFLA_VF_VLAN]);
vf_tx_rate = RTA_DATA(vf[IFLA_VF_TX_RATE]);
+ vf_spoofchk = RTA_DATA(vf[IFLA_VF_SPOOFCHK]);

fprintf(fp, "\n vf %d MAC %s", vf_mac->vf,
ll_addr_n2a((unsigned char *)&vf_mac->mac,
@@ -220,6 +222,10 @@ static void print_vfinfo(FILE *fp, struct rtattr
*vfinfo)
fprintf(fp, ", qos %d", vf_vlan->qos);
if (vf_tx_rate->rate)
fprintf(fp, ", tx rate %d (Mbps)", vf_tx_rate->rate);
+ if (vf_spoofchk->setting)
+ fprintf(fp, ", spoof checking on");
+ else
+ fprintf(fp, ", spoof checking off");
}

int print_linkinfo(const struct sockaddr_nl *who,
diff --git a/ip/iplink.c b/ip/iplink.c
index e5325a6..f4a5243 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -71,7 +71,10 @@ void iplink_usage(void)
fprintf(stderr, " [ alias NAME ]\n");
fprintf(stderr, " [ vf NUM [ mac LLADDR ]\n");
fprintf(stderr, " [ vlan VLANID [ qos VLAN-QOS ] ]\n");
+
fprintf(stderr, " [ rate TXRATE ] ] \n");
+
+ fprintf(stderr, " [ spoofchk { on | off} ] ] \n");
fprintf(stderr, " [ master DEVICE ]\n");
fprintf(stderr, " [ nomaster ]\n");
fprintf(stderr, " ip link show [ DEVICE | group GROUP ]\n");
@@ -228,6 +231,18 @@ int iplink_parse_vf(int vf, int *argcp, char ***argvp,
ivt.vf = vf;
addattr_l(&req->n, sizeof(*req), IFLA_VF_TX_RATE, &ivt, sizeof(ivt));

+ } else if (matches(*argv, "spoofchk") == 0) {
+ struct ifla_vf_spoofchk ivs;
+ NEXT_ARG();
+ if (matches(*argv, "on") == 0)
+ ivs.setting = 1;
+ else if (matches(*argv, "off") == 0)
+ ivs.setting = 0;
+ else
+ invarg("Invalid \"spoofchk\" value\n", *argv);
+ ivs.vf = vf;
+ addattr_l(&req->n, sizeof(*req), IFLA_VF_SPOOFCHK, &ivs, sizeof(ivs));
+
} else {
/* rewind arg */
PREV_ARG();
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index 27993a4..cd7b97a 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -100,7 +100,9 @@ ip \- show / manipulate routing, devices, policy
routing and tunnels
.B qos
.IR VLAN-QOS " ] ] ["
.B rate
-.IR TXRATE " ] |"
+.IR TXRATE " ] ["
+.B spoofchk { on | off }
+] |
.br
.B master
.IR DEVICE

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Stephen Hemminger <hidden>
Date: 2011-11-18 00:40:46

On Thu, 17 Nov 2011 15:39:32 -0800
Greg Rose [off-list ref] wrote:

On 9/25/2011 1:23 AM, Jeff Kirsher wrote:
quoted
From: Greg Rose <redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
I am limiting patches at this point to those that will build against 3.0.
The 3.1 version of iproute2 has not been released because kernel.org tool
to do the release is still in beta (kup), and they are working on it.

After 3.1 version of iproute2 is released, any fixes that require stuff
from 3.2 will go in.

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Greg Rose <hidden>
Date: 2011-11-18 00:43:09

On 11/17/2011 4:40 PM, Stephen Hemminger wrote:
On Thu, 17 Nov 2011 15:39:32 -0800
Greg Rose[off-list ref]  wrote:
quoted

On 9/25/2011 1:23 AM, Jeff Kirsher wrote:
quoted
From: Greg Rose<redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose<redacted>
Signed-off-by: Jeff Kirsher<redacted>
I am limiting patches at this point to those that will build against 3.0.
The 3.1 version of iproute2 has not been released because kernel.org tool
to do the release is still in beta (kup), and they are working on it.

After 3.1 version of iproute2 is released, any fixes that require stuff
from 3.2 will go in.
Great, sounds good.

Would you prefer that I Jeff (Kirsher) and I repost the patch at that time?

thanks,

- Greg
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Stephen Hemminger <hidden>
Date: 2011-11-18 00:45:31

On Thu, 17 Nov 2011 16:43:07 -0800
Greg Rose [off-list ref] wrote:
On 11/17/2011 4:40 PM, Stephen Hemminger wrote:
quoted
On Thu, 17 Nov 2011 15:39:32 -0800
Greg Rose[off-list ref]  wrote:
quoted

On 9/25/2011 1:23 AM, Jeff Kirsher wrote:
quoted
From: Greg Rose<redacted>

Add IP link command parsing for VF spoof checking enable/disable

Signed-off-by: Greg Rose<redacted>
Signed-off-by: Jeff Kirsher<redacted>
I am limiting patches at this point to those that will build against 3.0.
The 3.1 version of iproute2 has not been released because kernel.org tool
to do the release is still in beta (kup), and they are working on it.

After 3.1 version of iproute2 is released, any fixes that require stuff
from 3.2 will go in.
Great, sounds good.

Would you prefer that I Jeff (Kirsher) and I repost the patch at that time?
not required, if they show up in patchwork

Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check

From: Greg Rose <hidden>
Date: 2011-11-18 17:06:37

On 11/17/2011 4:45 PM, Stephen Hemminger wrote:
On Thu, 17 Nov 2011 16:43:07 -0800
Greg Rose[off-list ref]  wrote:
quoted
On 11/17/2011 4:40 PM, Stephen Hemminger wrote:
quoted
On Thu, 17 Nov 2011 15:39:32 -0800
Greg Rose[off-list ref]   wrote:
Would you prefer that I Jeff (Kirsher) and I repost the patch at that time?
not required, if they show up in patchwork
I see it under review in patchwork.

Thanks,

- Greg
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help