Re: [PATCH -next v2] unix stream: Fix use-after-free crashes
flat view
From: Tim Chen <hidden>
Date: 2011-09-06 16:37:26
On Sun, 2011-09-04 at 16:23 +0800, Yan, Zheng wrote:
On Sun, Sep 4, 2011 at 3:12 PM, Sedat Dilek [off-list ref] wrote:quoted
On Sun, Sep 4, 2011 at 7:44 AM, Yan, Zheng [off-list ref] wrote:quoted
Commit 0856a30409 (Scm: Remove unnecessary pid & credential references in Unix socket's send and receive path) introduced a use-after-free bug. It passes the scm reference to the first skb. Skb(s) afterwards may reference freed data structure because the first skb can be destructed by the receiver at anytime. The fix is by passing the scm reference to the very last skb.s/by passing/bypassing ?No
Maybe it is a clearer to say The fix is by withholding the scm reference obtained at the beginning of unix_stream_sendmsg via scm_send and pass it to the very last skb. Tim