Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.
From: Wolfgang Grandegger <hidden>
Date: 2011-08-11 16:35:50
Also in:
linux-devicetree, linuxppc-dev
On 08/11/2011 06:07 PM, Robin Holt wrote:
quoted hunk
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org> To: Kumar Gala <redacted> To: Wolfgang Grandegger <redacted>, To: Marc Kleine-Budde <redacted>, To: U Bhaskar-B22300 <redacted> To: Scott Wood <redacted> To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Cc: PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org --- .../devicetree/bindings/net/can/fsl-flexcan.txt | 2 + drivers/net/can/flexcan.c | 33 +++++++++++++++----- 2 files changed, 27 insertions(+), 8 deletions(-)diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt index c78dcbb..a4382c7 100644 --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt@@ -11,6 +11,7 @@ Required properties: - reg : Offset and length of the register set for this device - interrupts : Interrupt tuple for this device +- clock-frequency : The oscillator frequency driving the flexcan device Example:@@ -19,4 +20,5 @@ Example: reg = <0x1c000 0x1000>; interrupts = <48 0x2>; interrupt-parent = <&mpic>; + clock-frequency = <0x0bebc1fc>;
clock-frequency = <200000000>; // filled in by bootloader
Is better readable. You should also add the comment.
Wolfgang.