RE: [patch -next] bna: off by one in bfa_msgq_rspq_pi_update()

From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Wednesday, August 24, 2011 4:30 AM

The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was
off by one.

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/net/ethernet/brocade/bna/bfa_msgq.c

b/drivers/net/ethernet/brocade/bna/bfa_msgq.c
index ed52187..dd36427 100644

--- a/drivers/net/ethernet/brocade/bna/bfa_msgq.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_msgq.c

@@ -483,7 +483,7 @@ bfa_msgq_rspq_pi_update(struct bfa_msgq_rspq *rspq,

struct bfi_mbmsg *mb)
		mc = msghdr->msg_class;
		num_entries = ntohs(msghdr->num_entries);

-		if ((mc > BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
+		if ((mc >= BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
			break;

		(rspq->rsphdlr[mc].cbfn)(rspq->rsphdlr[mc].cbarg, msghdr);