[patch -next] bna: off by one in bfa_msgq_rspq_pi_update()

Subsystems: brocade bna 10 gigabit ethernet driver, networking drivers, the rest

STALE5525d

3 messages, 3 authors, 2011-08-26 · open the first message on its own page

[patch -next] bna: off by one in bfa_msgq_rspq_pi_update()

From: Dan Carpenter <hidden>
Date: 2011-08-24 11:32:45 

The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was
off by one.

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/net/ethernet/brocade/bna/bfa_msgq.c b/drivers/net/ethernet/brocade/bna/bfa_msgq.c
index ed52187..dd36427 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_msgq.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_msgq.c
@@ -483,7 +483,7 @@ bfa_msgq_rspq_pi_update(struct bfa_msgq_rspq *rspq, struct bfi_mbmsg *mb)
 		mc = msghdr->msg_class;
 		num_entries = ntohs(msghdr->num_entries);
 
-		if ((mc > BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
+		if ((mc >= BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
 			break;
 
 		(rspq->rsphdlr[mc].cbfn)(rspq->rsphdlr[mc].cbarg, msghdr);

RE: [patch -next] bna: off by one in bfa_msgq_rspq_pi_update()

From: Rasesh Mody <hidden>
Date: 2011-08-24 17:33:20

quoted hunk
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Wednesday, August 24, 2011 4:30 AM

The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was
off by one.

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/net/ethernet/brocade/bna/bfa_msgq.c
b/drivers/net/ethernet/brocade/bna/bfa_msgq.c
index ed52187..dd36427 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_msgq.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_msgq.c
@@ -483,7 +483,7 @@ bfa_msgq_rspq_pi_update(struct bfa_msgq_rspq *rspq,
struct bfi_mbmsg *mb)
		mc = msghdr->msg_class;
		num_entries = ntohs(msghdr->num_entries);

-		if ((mc > BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
+		if ((mc >= BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))
			break;

		(rspq->rsphdlr[mc].cbfn)(rspq->rsphdlr[mc].cbarg, msghdr);
Acked-by: Rasesh Mody <redacted>

Thanks,
Rasesh

Re: [patch -next] bna: off by one in bfa_msgq_rspq_pi_update()

From: David Miller <davem@davemloft.net>
Date: 2011-08-26 16:52:54 

From: Dan Carpenter <redacted>
Date: Wed, 24 Aug 2011 14:30:28 +0300

The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was
off by one.

Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help