Re: [RFC net-next PATCH 1/4] pci: Add flag indicating device has been assigned by KVM
From: Jeff Kirsher <hidden>
Date: 2011-07-30 04:00:42
On Fri, Jul 29, 2011 at 09:54, Konrad Rzeszutek Wilk [off-list ref] wrote:
quoted
quoted
quoted
quoted
On Wed, 2011-07-27 at 15:17 -0700, Greg Rose wrote:quoted
Device drivers that create and destroy SR-IOV virtual functions via calls to pci_enable_sriov() and pci_disable_sriov can causecatastrophicquoted
quoted
quoted
failures if they attempt to destroy VFs while they are assigned to guest virtual machines. By adding a flag for use by the KVM module to indicate that a device is assigned a device driver can check that flag and avoid destroying VFs while they are assigned and avoidsystemquoted
quoted
quoted
failures.OK, but I hope Xen can still use the dev_flag assignment bit.Yeah, I think the attached patch would do it, but I need to double check it. Do you have a git tree with this patchset?
Not yet, Greg was send these patches out as a RFC to make sure this was the correct direction to go.
Um, so you are fixing up ixgbe only - what about the cxgb4 and be driver? Shouldn't they also get some of this treatment?
Yes, Greg made changes to ixgbe to give an idea of what changes would need to be made with the suggested changes. From the feedback Greg received, there is definite changes needed. When Greg gets finished with the necessary changes to the kernel/ethtool, we will have a better idea of what changes are needed for the drivers. -- Cheers, Jeff