RE: [RFC net-next PATCH 4/4] ixgbe: Add support for new ethtool settings
From: Rose, Gregory V <hidden>
Date: 2011-07-28 15:52:21
-----Original Message----- From: Michał Mirosław [mailto:mirqus@gmail.com] Sent: Thursday, July 28, 2011 4:54 AM To: Rose, Gregory V Cc: netdev@vger.kernel.org; davem@davemloft.net; bhutchings@solarflare.com; Kirsher, Jeffrey T Subject: Re: [RFC net-next PATCH 4/4] ixgbe: Add support for new ethtool settings 2011/7/28 Greg Rose [off-list ref]:quoted
Adds ixgbe driver support for new ethtool settings for SR-IOV re-init, number of VM queues and anti-spoofing ON/OFF switch.[...]quoted
+static int ixgbe_reinit_sriov(struct net_device *netdev, int new_vfs) +{[...]quoted
+ if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { + adapter->flags &= ~(IXGBE_FLAG_RSS_ENABLED | + IXGBE_FLAG_DCB_ENABLED); + netdev->features &= ~NETIF_F_RXHASH; + } else { + adapter->flags |= IXGBE_FLAG_RSS_ENABLED; + netdev->features |= NETIF_F_RXHASH; + }Please use ndo_fix_features/ndo_set_features callbacks for this.
OK, sure. I'll add a separate patch to do that. - Greg