Re: [patch net-next-2.6 00/22] vlan cleanup round1

Sat, Jul 16, 2011 at 01:07:19AM CEST, jpirko@redhat.com wrote:

Sat, Jul 16, 2011 at 12:15:42AM CEST, mirqus@gmail.com wrote:

quoted

2011/7/15 Jiri Pirko [off-list ref]:

quoted

This patchset converts several drivers to new vlan model.
Also kills several vlan helpers:
vlan_hwaccel_receive_skb,
lro_vlan_hwaccel_receive_frags,
lro_vlan_hwaccel_receive_skb

It looks like most drivers that implement rx_add/kill_vid also need
bitmap recording all enabled VLANs. I think this could be done in
networking core for those devices in a generic way (set/clear before
corresponding rx_add/kill_vid call). The bitmap should be dynamically
allocated when needed (either on device registration time, or adding
first VLAN).

Problem is that for example in bonding, slaves do not have their
netdev->vlgrp set, they are not "officially" used by vlan code.
So their must maintain list of vids themselves. I would leave this as
it is atm and see what we can do later on.

Right, I'm going to think about it. I might repost this patchset after
that, So Dave please do not apply right away, thanks.

I will probably repost some of patches if my ndo_vlan_[enable/disable]
patch will be applied.

Jirka

quoted

This might be out of scope for this cleanup, though.

Looks good otherwise.

Best Regards,
Michał Mirosław