Re: [patch net-next-2.6 00/22] vlan cleanup round1
From: Michał Mirosław <hidden>
Date: 2011-07-15 22:16:03
2011/7/15 Jiri Pirko [off-list ref]:
This patchset converts several drivers to new vlan model. Also kills several vlan helpers: vlan_hwaccel_receive_skb, lro_vlan_hwaccel_receive_frags, lro_vlan_hwaccel_receive_skb
It looks like most drivers that implement rx_add/kill_vid also need bitmap recording all enabled VLANs. I think this could be done in networking core for those devices in a generic way (set/clear before corresponding rx_add/kill_vid call). The bitmap should be dynamically allocated when needed (either on device registration time, or adding first VLAN). This might be out of scope for this cleanup, though. Looks good otherwise. Best Regards, Michał Mirosław