Thread (5 messages) flat view 5 messages, 2 authors, 2011-07-15

Re: [PATCH 07/10] net: remove NETIF_F_NO_CSUM feature

From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-07-14 22:44:46

On Thu, Jul 14, 2011 at 02:31:21PM -0700, David Miller wrote:
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Thu, 14 Jul 2011 22:56:23 +0200
quoted
That's why its turned off by default and should be enabled only when user
knows he will win some pps with it.
More people are going to lose than win by your change.

The nocopy feature helps more real situations than it hurts, the
existing default is the best.
I see. I still want to remove NO_CSUM (as I explained in other mail),
so would you accept replacing it with something more specific to
nocache-copy feature? READS_DATA maybe? That could be later added to
sk_route_caps whenever it's known for a route there will be need to
read packets' data.

Best Regards,
Michał Mirosław
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help