[net-next 1/4] igb: Fix lack of flush after register write and before delay

STALE5580d SUPERSEDED: 1 (0M)

From: Jeff Kirsher <hidden>
Date: 2011-07-12 02:15:17
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Revision v1 of 33 in this series; 1 review trailer.

Revisions (33)

2011-03-15 v1
2011-04-14 v1
2011-04-27 v1
2011-05-04 v1
2011-05-07 v1
2011-05-15 v1
2011-06-07 v1
2011-06-08 v1
2011-06-10 v2 [diff vs current]
2011-06-11 v1
2011-06-20 v1
2011-06-21 v1
2011-06-23 v1
2011-06-24 v1
2011-06-25 v1
2011-07-09 v1
2011-07-12 v1 current
2011-07-22 v1
2011-07-22 v2 [diff vs current]
2011-08-04 v1
2011-08-19 v1
2011-08-21 v1
2011-08-27 v1
2011-08-29 v1
2011-09-20 v1
2011-09-21 v1
2011-10-12 v1
2011-11-03 v1
2012-02-02 v1
2012-02-03 v2 [diff vs current]
2012-04-04 v1
2012-04-05 v1
2012-06-02 v1

From: Carolyn Wyborny <redacted>

Register writes followed by a delay are required to have a flush
before the delay in order to commit the values to the register.  Without
the flush, the code following the delay may not function correctly.

Reported-by: Tong Ho <redacted>
Reported-by: Guenter Roeck <redacted>
Signed-off-by: Carolyn Wyborny <redacted>
Tested-by:  Aaron Brown <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 drivers/net/igb/e1000_82575.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/igb/e1000_82575.c b/drivers/net/igb/e1000_82575.c
index 0f563c8..493e331 100644
--- a/drivers/net/igb/e1000_82575.c
+++ b/drivers/net/igb/e1000_82575.c

@@ -1735,6 +1735,7 @@ static s32 igb_reset_hw_82580(struct e1000_hw *hw)
 		ctrl |= E1000_CTRL_RST;
 
 	wr32(E1000_CTRL, ctrl);
+	wrfl();
 
 	/* Add delay to insure DEV_RST has time to complete */
 	if (global_device_reset)

-- 
1.7.6

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help