Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

On Tue, 2011-06-14 at 11:21 +0200, Geert Uytterhoeven wrote:

quoted

On Tue, Jun 14, 2011 at 06:02, Joe Perches [off-list ref] wrote:

quoted

Unnecessary casts of void * clutter the code.

--- a/drivers/net/a2065.c
+++ b/drivers/net/a2065.c

@@ -426,7 +426,7 @@ static irqreturn_t lance_interrupt (int irq, void *dev_id)

       volatile struct lance_regs *ll;
       int csr0;

-       dev = (struct net_device *) dev_id;
+       dev = dev_id;

I think it would look better if you merge this line with the line that
defines "dev".

I think so too, but I also think it should look like below
and that's something better done in a separate pass, don't
you think?

diff --git a/drivers/net/a2065.c b/drivers/net/a2065.c
index deaa8bc..25ea98a 100644
--- a/drivers/net/a2065.c
+++ b/drivers/net/a2065.c

@@ -421,16 +421,11 @@ static int lance_tx (struct net_device *dev)

 static irqreturn_t lance_interrupt (int irq, void *dev_id)
 {
-       struct net_device *dev;
-       struct lance_private *lp;
-       volatile struct lance_regs *ll;
+       struct net_device *dev = dev_id;
+       struct lance_private *lp = netdev_priv(dev);
+       volatile struct lance_regs *ll = lp->ll;
       int csr0;

-       dev = (struct net_device *) dev_id;
-
-       lp = netdev_priv(dev);
-       ll = lp->ll;
-
       ll->rap = LE_CSR0;              /* LANCE Controller Status */
       csr0 = ll->rdp;