Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *
From: Debashis Dutt <hidden>
Date: 2011-06-14 07:56:26
Also in:
lkml
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/bna/bfa_cee.c b/drivers/net/bna/bfa_cee.c index f7b789a..dcfbf08 100644 --- a/drivers/net/bna/bfa_cee.c +++ b/drivers/net/bna/bfa_cee.c@@ -236,7 +236,7 @@ static voidbfa_cee_hbfail(void *arg) { struct bfa_cee *cee; - cee = (struct bfa_cee *) arg; + cee = arg; if (cee->get_attr_pending == true) { cee->get_attr_status = BFA_STATUS_FAILED;diff --git a/drivers/net/bna/cna.h b/drivers/net/bna/cna.h index bbd39dc..3c47dc5 100644 --- a/drivers/net/bna/cna.h +++ b/drivers/net/bna/cna.h@@ -74,7 +74,7 @@ typedef struct mac { u8 mac[MAC_ADDRLEN]; } mac_t;bfa_q_next(_q) = bfa_q_next(*((struct list_head **) _qe)); \ bfa_q_qe_init(*((struct list_head **) _qe)); \ } else { \ - *((struct list_head **) (_qe)) = (struct list_head *) NULL; \ + *((struct list_head **)(_qe)) = NULL; \ } \ }
"bna" patches look good. Thanks --Debashis