Re: [PATCH 07/11] fs_enet: enable transmit time stamping.

On Sun, Jun 19, 2011 at 08:30:49PM +0200, Eric Dumazet wrote:

Le dimanche 19 juin 2011 à 20:12 +0200, Richard Cochran a écrit :

quoted

Thanks for your review. I have posted a fix for the first batch (since
they are already in next) and reposted this series.

But, considering your point, it looks like pxa168_eth and mv643xx_eth
(see patches 9 and 10 of this series) already access skb->len unsafely.

Would you care to comment on those spots, too?

They certainly are buggy, at a first glance.

Not only skb->len is unsafe, but netif_tx_stop_queue() calls are unsafe
too.

Out of the MAC drivers in my two batches, only drivers/net/tg3.c calls
netif_tx_stop_queue(txq);

However, I don't know how to fix that. Anyone else care to take a look?

Thanks,

Richard