Re: [PATCH 10/11] mv643xx_eth: enable transmit time stamping.

Le dimanche 19 juin 2011 à 20:17 +0200, Richard Cochran a écrit :

On Sun, Jun 19, 2011 at 01:20:06PM +0200, Richard Cochran wrote:

quoted

This patch enables software (and phy device) transmit time stamping.
Compile tested only.

Cc: Lennert Buytenhek <redacted>
Signed-off-by: Richard Cochran <redacted>
---
 drivers/net/mv643xx_eth.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index a5d9b1c..c7a8f10 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c

@@ -884,6 +884,8 @@ static netdev_tx_t mv643xx_eth_xmit(struct sk_buff *skb, struct net_device *dev)
 	if (!txq_submit_skb(txq, skb)) {
 		int entries_left;
 
+		skb_tx_timestamp(skb);
+
 		txq->tx_bytes += skb->len;

And the line above is unsafe, as well.

Yes, for sure, please submit patches to fix this (before adding time
stamping patches), as this should go to stable.