-----Original Message-----
From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Tuesday, June 14, 2011 11:52 AM
To: Wyborny, Carolyn
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature
config to ethtool.

Carolyn Wyborny wrote:

quoted

This RFC patch adds functions to get and set DMA Coalescing feature
configuration.

Signed-off-by: Carolyn Wyborny <redacted>
---
 include/linux/ethtool.h |   15 ++++++++++++++-
 net/core/ethtool.c      |   32 ++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletions(-)

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index c6a850a..efed754 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h

@@ -703,6 +703,14 @@ enum ethtool_sfeatures_retval_bits {
 	ETHTOOL_F_COMPAT__BIT,
 };

+/* for configuring DMA coalescing parameters of chip */
+struct ethtool_dmac {
+	__u32	cmd;	/* ETHTOOL_{G,S}DMAC */
+
+	/* tune setting, options and validation determined by device. */
+	__u32	tune;
+};

[...]

I don't think we should be adding operations that have no generic
semantics at all.  Further, we will not add any operations without at
least one implementation as an example.

Secondly, ethtool operations that only get/set a 32-bit value should
use struct ethtool_value for the parameter.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Ok, will send up update with the suggested changes and an implementation as an example.  I have one, but will wait to synch it with the updated patch.  Do you want another RFC or a regular patch submission?

Thanks,

Carolyn

Carolyn Wyborny
Linux Development
LAN Access Division
Intel Corporation