Re: [PATCH 15/15] ehea: Remove unused tcp_end field in send WQ

On Wed, 2011-05-11 at 20:12 -0700, Joe Perches wrote:

On Wed, 2011-05-11 at 23:06 -0400, David Miller wrote:

quoted

From: Joe Perches <joe@perches.com>
Date: Wed, 11 May 2011 19:31:13 -0700

quoted

On Thu, 2011-05-12 at 10:52 +1000, Anton Blanchard wrote:

quoted

plain text document attachment (ehea_22.patch)
The tcp_end field is not actually used by the hardware, so there
is no need to set it. 

+++ linux-net/drivers/net/ehea/ehea_qmr.h	2011-05-12 07:48:06.380382084 +1000

@@ -106,7 +106,7 @@ struct ehea_swqe {
 	u8 immediate_data_length;
 	u8 tcp_offset;
 	u8 reserved2;
-	u16 tcp_end;
+	u16 reserved2b;
 	u8 wrap_tag;
 	u8 descriptors;		/* number of valid descriptors in WQE */
 	u16 reserved3;

struct ehea_swqe isn't __packed.  Shouldn't it be?

Please don't mark it __packed unless absolutely necessary :-)

Isn't it read from hardware.
If not, why reserve anything?

All the fields have the required alignment, so __packed shouldn't be
necessary but won't hurt either. Yes, it's a HW accessed structure.

Cheers,
Ben.