Thread (28 messages) flat view 28 messages, 6 authors, 2011-05-31

Re: [PATCH 03/15] ehea: Remove force_irq logic in napi poll routine

From: David Miller <davem@davemloft.net>
Date: 2011-05-12 03:09:23

From: Joe Perches <joe@perches.com>
Date: Wed, 11 May 2011 19:31:10 -0700
On Thu, 2011-05-12 at 10:52 +1000, Anton Blanchard wrote:
quoted
commit 18604c548545 (ehea: NAPI multi queue TX/RX path for SMP) added
driver specific logic for exiting napi mode. I'm not sure what it was
trying to solve and it should be up to the network stack to decide when
we are done polling so remove it.
Signed-off-by: Anton Blanchard <redacted>
quoted
+++ linux-net/drivers/net/ehea/ehea_main.c	2011-05-12 07:47:51.960153456 +1000
@@ -937,18 +936,13 @@ static int ehea_poll(struct napi_struct
[]
quoted
+	while ((rx != budget)) {
one level of parentheses is enough.
Agreed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help