Re: [PATCH 17/34] hdlcdrv: Drop __TIME__ usage
From: Michal Marek <hidden>
Date: 2011-04-19 10:56:50
Also in:
linux-hams, linux-kbuild
From: Michal Marek <hidden>
Date: 2011-04-19 10:56:50
Also in:
linux-hams, linux-kbuild
On 19.4.2011 12:17, walter harms wrote:
Am 05.04.2011 16:59, schrieb Michal Marek:quoted
--- a/drivers/net/hamradio/hdlcdrv.c +++ b/drivers/net/hamradio/hdlcdrv.c@@ -749,7 +749,7 @@ EXPORT_SYMBOL(hdlcdrv_unregister); static int __init hdlcdrv_init_driver(void) { printk(KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n"); - printk(KERN_INFO "hdlcdrv: version 0.8 compiled " __TIME__ " " __DATE__ "\n"); + printk(KERN_INFO "hdlcdrv: version 0.8\n"); return 0; }Its a bit late but i am not a big fan of hard coded version id's. Does GIT provide something like that ? If not IMHO the line printk(KERN_INFO "hdlcdrv: version 0.8\n"); can be removed.
OK, submit a separate patch then. I personally don't care about version id's, as long as they do not embed any timestamp ;-). Michal