On Wed, Jan 26, 2011 at 01:47:46AM -0800, Jeff Kirsher wrote:

2011/1/22 Michał Mirosław [off-list ref]:

quoted

Private rx_csum flags are now duplicate of netdev->features & NETIF_F_RXCSUM.
Removing this needs deeper surgery.

Since ixgbevf doesn't change hardware state on RX csum enable/disable
its reset is avoided.

Things noticed:
 - e1000, e1000e and ixgb have RX csum disabled by default
 - HW VLAN acceleration probably can be toggled, but it's left as is
 - the resets on RX csum offload change can probably be avoided
 - there is A LOT of copy-and-pasted code here

[...]

Upon initial reviews of the patch, we found issues with the e1000e
changes so far.  We are working to put together a patch to resolve the
issues (and to do the conversion to ndo_fix_features).  Based on the
initial work done by Michal, we can take care of the changes necessary
for the Intel Wired Ethernet drivers, and will wait for acceptance of
the net and ethtool changes before pushing the Intel patch.  Is that
acceptable?

For e1000e, this patch breaks the ability to manually override the
default behavior of disabling TSO for 10/100, and there is some
additional cleanup that can be done w.r.t. Rx csum flags.

I resent other patches after the ethtool changes got it 2.6.39-rc, but skipped
this one based on your mail. Do you want me to resend parts not relevant
to e1000e or can I drop it altogether from my queue?

Best Regards,
Michał Mirosław