Re: [PATCH v2 16/16] skge: convert to hw_features
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-01-31 22:40:33
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-01-31 22:40:33
On Mon, Jan 31, 2011 at 10:53:43PM +0100, Michał Mirosław wrote:
On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote:quoted
On Sat, 22 Jan 2011 23:14:14 +0100 (CET) Michał Mirosław [off-list ref] wrote:quoted
The hardware might do full HW_CSUM, not just IP_CSUM, but it's not tested and so not changed here. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>The skge hardware does not do full HW_CSUM. It looks at the IP header.Driver code suggests otherwise. Please look at skge_xmit_frame() and TX descriptor format. Besides, I'm locally using a patch that makes skge advertise HW_CSUM - TCP over IPv6 is correctly checksummed in hardware (haven't tried VLANs yet).
IPv4 UDP inside VLAN-tagged packet is also checksummed properly by hardware. I don't have time now to make a proper HW_CSUM test (with arbitrary header prepended). If someone has one (or patches?), I'd be glad to use it, though. Best Regards, Michał Mirosław