Thread (14 messages) 14 messages, 6 authors, 2011-04-07

Re: [PATCH] xen: netfront: fix declaration order

From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-04-03 17:35:29
Also in: xen-devel

On Sun, Apr 03, 2011 at 01:07:19PM +0200, Eric Dumazet wrote:
Le vendredi 01 avril 2011 à 20:54 -0700, David Miller a écrit :
quoted
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST)
quoted
Not tested in any way. The original code for offload setting seems broken
as it resets the features on every netback reconnect.

This will set GSO_ROBUST at device creation time (earlier than connect time).

RX checksum offload is forced on - so advertise as it is.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Applied.
Hmm... I had to apply following patch to make it actually compile.
[PATCH] xen: netfront: fix declaration order

Must declare xennet_fix_features() and xennet_set_features() before
using them.
Hmm. Sorry for that. Looks like x86 allyesconfig doesn't include this
driver in the build. :/

There really needs to be something like CONFIG_LINT...

Best Regards,
Michał Mirosław
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help