Re: [RFC PATCH] net/core: fix skb handling on netif serves for both bridge and vlan

Le 05/03/2011 11:36, Jiri Pirko a écrit :

Thu, Mar 03, 2011 at 11:55:13AM CET, dfeng@redhat.com wrote:

quoted

Consider network topology as follows:

eth0  eth1
|_____|
    |
  bond0 --- br0
    |
  vlan0 --- br1

bond0 serves for both br0 and vlan0, if a vlan tagged packet was sent
to br1 through bond0, bridge handling code is seeing the packet on bond0
and handing it off to my "legacy" bridge before vlan_tx_tag_present
and vlan_hwaccel_do_receive even haven't a chance to look at it.

Moving the vlan_tx_tag_present before bridge/macvlan handling code could
cure this.

Wouldn't this break "eth0 - br0 - br0.5"?

I think it would. One more reason to build a single interface stacking framework...

	Nicolas.