Re: [PATCH v2] net: provide default_advmss() methods to blackhole dst_ops

From: Eric Dumazet <redacted>
Date: Fri, 18 Feb 2011 14:44:32 +0100

Le vendredi 18 février 2011 à 14:33 +0100, Eric Dumazet a écrit :

quoted

I had this exact idea but found we need struct net pointer to get this
value, not provided in parameters, so I falled back to the 256 value.

Hmm, reading again this stuff, maybe we can just use
ipv4_default_advmss() instead of a custom one.

dst->dev should be available

[PATCH] net: provide default_advmss() methods to blackhole dst_ops

Commit 0dbaee3b37e118a (net: Abstract default ADVMSS behind an
accessor.) introduced a possible crash in tcp_connect_init(), when
dst->default_advmss() is called from dst_metric_advmss()

Reported-by: George Spelvin <redacted>
Signed-off-by: Eric Dumazet <redacted>

Yes, this is a lot better, applied.

Thanks!