Re: [PATCH] net: Add default_advmss() methods to blackhole dst_ops

Le vendredi 18 février 2011 à 21:29 +0800, Changli Gao a écrit :

On Fri, Feb 18, 2011 at 9:24 PM, Eric Dumazet [off-list ref] wrote:

quoted

Le vendredi 18 février 2011 à 21:16 +0800, Changli Gao a écrit :

quoted

I am wondering why magic number 256 is used here. Is there a special
reason? Thanks.

It really doesnt matter. SYN message will be dropped anyway.

256 happens to be the default value
of /proc/sys/net/ipv4/route/min_adv_mss

Thanks for your explaining. IMHO, ip_rt_min_advmss is better than a
magic number, here.

I had this exact idea but found we need struct net pointer to get this
value, not provided in parameters, so I falled back to the 256 value.