Thread (4 messages) 4 messages, 3 authors, 2011-02-01

Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-02-01 20:29:38
Also in: lkml

From: Ramkrishna Vepa <redacted>
Date: Mon, 31 Jan 2011 23:26:40 -0800
quoted
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
always evaluates to true. Did you intend to use && instead?

It looks like cppcheck is correct, so fix this. No test was run.

Signed-off-by: Stefan Weil <redacted>
...
Fix looks good. Thanks!

Acked-by: Ram Vepa <redacted>
Thanks for reviewing, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help