[PATCH] vxge: Fix wrong boolean operator

Subsystems: networking drivers, the rest

STALE5734d

4 messages, 3 authors, 2011-02-01 · open the first message on its own page

[PATCH] vxge: Fix wrong boolean operator

From: Stefan Weil <hidden>
Date: 2011-01-28 22:30:28

This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?

It looks like cppcheck is correct, so fix this. No test was run.

Cc: Ramkrishna Vepa <redacted>
Cc: Sivakumar Subramani <redacted>
Cc: Sreenivasa Honnur <redacted>
Cc: Jon Mason <redacted>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <redacted>
---
 drivers/net/vxge/vxge-config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-config.c
index 01c05f5..228d4f7 100644
--- a/drivers/net/vxge/vxge-config.c
+++ b/drivers/net/vxge/vxge-config.c
@@ -3690,7 +3690,7 @@ __vxge_hw_vpath_rts_table_get(struct __vxge_hw_vpath_handle *vp,
 	if (status != VXGE_HW_OK)
 		goto exit;
 
-	if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA) ||
+	if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA) &&
 	    (rts_table !=
 	     VXGE_HW_RTS_ACS_STEER_CTRL_DATA_STRUCT_SEL_RTH_MULTI_IT))
 		*data1 = 0;
-- 
1.7.2.3

Re: [PATCH] vxge: Fix wrong boolean operator

From: David Miller <davem@davemloft.net>
Date: 2011-02-01 04:55:20

From: Stefan Weil <redacted>
Date: Fri, 28 Jan 2011 23:30:17 +0100
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?

It looks like cppcheck is correct, so fix this. No test was run.

Cc: Ramkrishna Vepa <redacted>
Cc: Sivakumar Subramani <redacted>
Cc: Sreenivasa Honnur <redacted>
Cc: Jon Mason <redacted>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <redacted>
Can the VXGE folks please review this patch?

RE: [PATCH] vxge: Fix wrong boolean operator {nodisc}

From: Ramkrishna Vepa <hidden>
Date: 2011-02-01 07:26:45

quoted hunk
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
always evaluates to true. Did you intend to use && instead?

It looks like cppcheck is correct, so fix this. No test was run.

Signed-off-by: Stefan Weil <redacted>
---
 drivers/net/vxge/vxge-config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-
config.c
index 01c05f5..228d4f7 100644
--- a/drivers/net/vxge/vxge-config.c
+++ b/drivers/net/vxge/vxge-config.c
@@ -3690,7 +3690,7 @@ __vxge_hw_vpath_rts_table_get(struct
__vxge_hw_vpath_handle *vp,
 	if (status != VXGE_HW_OK)
 		goto exit;

-	if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA)
||
+	if ((rts_table != VXGE_HW_RTS_ACCESS_STEER_CTRL_DATA_STRUCT_SEL_DA)
&&
 	    (rts_table !=
 	     VXGE_HW_RTS_ACS_STEER_CTRL_DATA_STRUCT_SEL_RTH_MULTI_IT))
 		*data1 = 0;
--
Fix looks good. Thanks!

Acked-by: Ram Vepa <redacted>

Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}

From: David Miller <davem@davemloft.net>
Date: 2011-02-01 20:29:38

From: Ramkrishna Vepa <redacted>
Date: Mon, 31 Jan 2011 23:26:40 -0800
quoted
This error is reported by cppcheck:
drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
always evaluates to true. Did you intend to use && instead?

It looks like cppcheck is correct, so fix this. No test was run.

Signed-off-by: Stefan Weil <redacted>
...
Fix looks good. Thanks!

Acked-by: Ram Vepa <redacted>
Thanks for reviewing, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help