Hi Sascha,
On Fri, Jan 14, 2011 at 09:16:56PM +0800, Shawn Guo wrote:
On Fri, Jan 14, 2011 at 09:33:20AM +0100, Sascha Hauer wrote:
quoted
On Thu, Jan 13, 2011 at 04:19:39PM +0100, Uwe Kleine-König wrote:
quoted
On Thu, Jan 06, 2011 at 03:13:16PM +0800, Shawn Guo wrote:
quoted
Signed-off-by: Shawn Guo <redacted>
---
Changes for v4:
- Call cpu_relax() during polling
Changes for v2:
- Add mutex locking for mxs_read_ocotp()
- Use type size_t for count and i
- Add comment for clk_enable/disable skipping
- Add ERROR bit clearing and polling step
arch/arm/mach-mxs/Makefile | 2 +-
arch/arm/mach-mxs/include/mach/common.h | 1 +
arch/arm/mach-mxs/ocotp.c | 79 +++++++++++++++++++++++++++++++
3 files changed, 81 insertions(+), 1 deletions(-)
create mode 100644 arch/arm/mach-mxs/ocotp.c
diff --git a/arch/arm/mach-mxs/Makefile b/arch/arm/mach-mxs/Makefile
index 39d3f9c..f23ebbd 100644
--- a/arch/arm/mach-mxs/Makefile
+++ b/arch/arm/mach-mxs/Makefile
@@ -1,5 +1,5 @@
# Common support
-obj-y := clock.o devices.o gpio.o icoll.o iomux.o system.o timer.o
+obj-y := clock.o devices.o gpio.o icoll.o iomux.o ocotp.o system.o timer.o
is it worth to make ocotp optional? (and let evk select
CONFIG_MXS_OCOTP)
I think not.
I thought it depends on how we think about it. If we think that
ocotp is a block of soc and should be on every system based on
the soc, we should build it unconditional. However, if we think
ocotp is a function that could either be used on a machine or not,
it should be built conditional, so that the machine does not use
ocotp function could save the ocotp build and the memory of
u32 ocotp_words[0x20].
You've not merged patch #8, #9, #10, so you still think
CONFIG_MXS_OCOTP should not be added?
--
Regards,
Shawn