Re: [PATCH v4 05/10] net/fec: add dual fec support for mx28
From: Uwe Kleine-König <hidden>
Date: 2011-01-11 13:07:50
Also in:
linux-arm-kernel
Hi Greg, On Tue, Jan 11, 2011 at 10:24:12PM +1000, Greg Ungerer wrote:
On 11/01/11 20:27, Sascha Hauer wrote:quoted
On Thu, Jan 06, 2011 at 03:13:13PM +0800, Shawn Guo wrote: This option is used nowhere and should be removed. Certainly it does not have the effect of enabling the second ethernet controller.It does for a ColdFire platform... grep -r CONFIG_FEC2 * arch/m68knommu/configs/m5275evb_defconfig:CONFIG_FEC2=y arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2 arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2
IMHO Sascha's comment[1] applies here, too. And someone might want to do what he suggested soon or the patch removing CONFIG_FEC2[2] needs to be commented accordingly. Best regards Uwe [1] http://thread.gmane.org/gmane.linux.network/182929/focus=183378 [2] http://mid.gmane.org/1294747672-4433-1-git-send-email-shawn.guo@freescale.com -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |